Skip to content

feat: Add support/config for InstanceSegmentationMask#5

Draft
aranega wants to merge 40 commits into
mainfrom
feature/CC-429
Draft

feat: Add support/config for InstanceSegmentationMask#5
aranega wants to merge 40 commits into
mainfrom
feature/CC-429

Conversation

@aranega
Copy link
Copy Markdown
Member

@aranega aranega commented Sep 4, 2025

Relates to

Description

@aranega aranega requested a review from seankmartin September 4, 2025 14:25
Copy link
Copy Markdown

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few markers for potential questions

Comment thread ingestion_tools/dataset_configs/template.yaml
Comment thread schema/core/v1.1.0/metadata.yaml Outdated
Comment thread schema/core/v1.1.0/metadata.yaml Outdated
Comment thread schema/core/v2.0.0/metadata.yaml Outdated
Copy link
Copy Markdown

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again just leaving some notes for us :)

Comment thread ingestion_tools/dataset_configs/template.yaml Outdated
Comment thread ingestion_tools/scripts/importers/annotation.py Outdated
Comment thread ingestion_tools/scripts/importers/visualization_config.py Outdated
Comment thread ingestion_tools/scripts/importers/visualization_config.py
Copy link
Copy Markdown

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small question, looks good overall, thanks!

Comment thread ingestion_tools/scripts/importers/annotation.py Outdated
Comment thread ingestion_tools/scripts/common/image.py Outdated
Copy link
Copy Markdown

@seankmartin seankmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great thanks! Left a few comments

Comment thread ingestion_tools/poetry.lock Outdated
Comment thread ingestion_tools/scripts/common/image.py Outdated
Comment thread ingestion_tools/scripts/common/image.py Outdated
Comment thread ingestion_tools/scripts/common/image.py Outdated
Comment thread schema/ingestion_config/v1.0.0/codegen/ingestion_config_models.py
Comment thread apiv2/schema/schema.yaml
Comment thread apiv2/database/migrations/versions/20250819_111511_autogenerated.py
Comment thread apiv2/database/migrations/versions/20250819_111511_autogenerated.py
Comment thread ingestion_tools/scripts/common/image.py
Comment thread schema/ingestion_config/v1.0.0/ingestion_config_models.yaml Outdated
Comment thread schema/core/v1.1.0/metadata.yaml
aranega and others added 9 commits October 31, 2025 05:30
…g#544)

* fix: provide a way to scale oriented mesh files

* fix: auto compute scale correctly

* refactor: pass clearer parameter to encode_mesh

* refactor: pass clearer scale parameter

* fix: remove test on face number increase

* chore: update dependent python neuroglancer package version
* NPC-1 ingestion config.

* fix formatting

* add authors

* add additional authors

* add funding

* daniel's edits + raw data

* fix validation errors

* fix path

* fix path

* fix voxel size

* consistent capitalization.

* fix mesh path.

* add missing organism

* add keyphotos
…ic vesicles from mouse brain (chanzuckerberg#538)

* fix linkml dep, add missing ontology ids, add ingestion config for EMPIAR 12794 - isolated synaptic vesicles from mouse brain

* small fixes

* add Gctf support and fix docs

* Update ingestion_tools/dataset_configs/10453.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update ingestion_tools/scripts/common/ctf_converter.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix 10453 config

* fix 10453 config

* fix 10453 config pt.3

* fix 10453 config pt.4

* fix 10453 config again

* fix 10453 config

* fix 10453 config again

* ingestion config and ingestion validation fixes

* fix ingestion validation tests

* fix annotation import and metadata for 10453

* fix memory spike issue of tiltseries ingestion and also have more robust gain ingestion

* linting fix

* fix staging neuroglancer config https prefix bug

* bugfix enqueue_runs

* fix multiscale data writing and add chunking

* work on zarr data chunking and writing

* revert https prefix for ng, adding to separate pr

* update dataset and deposition dates

* add keyphotos

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: uermel <uermel@czii.org>
…m viewer) (chanzuckerberg#545)

* fix linkml dep, add missing ontology ids, add ingestion config for EMPIAR 12794 - isolated synaptic vesicles from mouse brain

* small fixes

* add Gctf support and fix docs

* Update ingestion_tools/dataset_configs/10453.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update ingestion_tools/scripts/common/ctf_converter.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix 10453 config

* fix 10453 config

* fix 10453 config pt.3

* fix 10453 config pt.4

* fix 10453 config again

* fix 10453 config

* fix 10453 config again

* ingestion config and ingestion validation fixes

* fix ingestion validation tests

* fix annotation import and metadata for 10453

* fix memory spike issue of tiltseries ingestion and also have more robust gain ingestion

* linting fix

* fix staging neuroglancer config https prefix bug

* bugfix enqueue_runs

* fix multiscale data writing and add chunking

* work on zarr data chunking and writing

* revert https prefix for ng, adding to separate pr

* add https prefix to enqueue runs / standardize dirs to fix ng config gen

* auto https_prefix replacement during ng config db import

* update dataset and deposition dates

* add keyphotos

* update config, add --import-all-metadata to ingestion

* simpler dynamic url replacement during db import, use prod URLs in staging, other small fixes

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: uermel <uermel@czii.org>
Co-authored-by: Utz Ermel <uermel@users.noreply.github.com>
* chore(main): release apiv2 1.14.0

* chore: Updated [staging,prod] values.yaml image tags to sha-3a64fa9

---------

Co-authored-by: czi-github-helper[bot] <95879977+czi-github-helper[bot]@users.noreply.github.com>
Co-authored-by: czi-github-helper[bot] <+czi-github-helper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants